Add support to clone existing offerings and update them by Pearl1594 · Pull Request #12357 · apache/cloudstack

Pearl1594 · 2025-12-31T16:20:44Z

Description

This PR adds APIs to clone existing offerings - service, system, network, VPC, backup and update certain parameters of the existing offering.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2025-12-31T16:27:13Z

Codecov Report

❌ Patch coverage is 56.67412% with 581 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.19%. Comparing base (a5b6bc3) to head (9907d5a).
⚠️ Report is 14 commits behind head on main.

Files with missing lines	Patch %	Lines
...ain/java/com/cloud/network/vpc/VpcManagerImpl.java	0.48%	205 Missing and 2 partials ⚠️
.../cloud/configuration/ConfigurationManagerImpl.java	77.70%	105 Missing and 62 partials ⚠️
.../command/admin/network/NetworkOfferingBaseCmd.java	29.64%	129 Missing and 11 partials ⚠️
...rg/apache/cloudstack/backup/BackupManagerImpl.java	48.88%	11 Missing and 12 partials ⚠️
...i/command/admin/backup/CloneBackupOfferingCmd.java	66.00%	17 Missing ⚠️
...i/command/admin/offering/CloneDiskOfferingCmd.java	0.00%	13 Missing ⚠️
...ack/api/command/admin/vpc/CloneVPCOfferingCmd.java	60.00%	10 Missing ⚠️
...in/java/com/cloud/server/ManagementServerImpl.java	0.00%	4 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #12357      +/-   ##
============================================
+ Coverage     17.89%   18.19%   +0.29%     
- Complexity    16092    16604     +512     
============================================
  Files          5936     5952      +16     
  Lines        532734   541105    +8371     
  Branches      65165    68497    +3332     
============================================
+ Hits          95347    98443    +3096     
- Misses       426711   431599    +4888     
- Partials      10676    11063     +387

Flag	Coverage Δ
uitests	`3.54% <ø> (-0.14%)`	⬇️
unittests	`19.35% <56.67%> (+0.35%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-01-19T12:10:08Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

…e-edit-existing-offerings

…tris from the source networkmode

Copilot

Pull request overview

This PR introduces “clone offering” functionality across the CloudStack API and UI, enabling users to clone existing offerings (compute/service, disk, network, VPC, backup) while overriding selected parameters. It also refactors network/VPC service-capability param building into shared UI helpers and wires the new actions into the offerings UI.

Changes:

Added new API commands and server implementations for cloning multiple offering types (plus event types and service interfaces).
Added new UI clone views (compute/disk/backup shown here) and integrated clone actions into the offerings section config.
Refactored network/VPC service-capability parameter construction into a shared composable and extracted disk offering form into a reusable component.

Reviewed changes

Copilot reviewed 41 out of 41 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
ui/src/views/offering/CloneDiskOffering.vue	New UI flow to clone disk offerings using the shared `DiskOfferingForm`.
ui/src/views/offering/CloneComputeOffering.vue	New UI flow to clone compute/service offerings (includes prefill + submit logic).
ui/src/views/offering/CloneBackupOffering.vue	New UI flow to clone backup offerings (zone/provider offering selection + async job polling).
ui/src/views/offering/AddVpcOffering.vue	Refactors VPC service capability param building into a shared helper.
ui/src/views/offering/AddNetworkOffering.vue	Refactors network service capability param building into a shared helper.
ui/src/views/offering/AddDiskOffering.vue	Refactors disk offering creation to use the new shared `DiskOfferingForm` component.
ui/src/config/section/offering.js	Adds new “Clone * Offering” actions in the UI offerings sections.
ui/src/composables/useServiceCapabilityParams.js	New shared helper(s) to build serviceCapability/serviceProvider param sets for network/VPC offerings.
ui/src/components/offering/DiskOfferingForm.vue	New reusable disk offering form component extracted from the previous view.
ui/src/components/CheckBoxSelectPair.vue	Adds support for setting a default select value.
ui/public/locales/en.json	Adds i18n strings for clone offering actions and messages.
server/src/test/java/org/apache/cloudstack/backup/BackupManagerTest.java	Adds tests asserting cloned backup offering domain handling.
server/src/test/java/com/cloud/vpc/MockConfigurationManagerImpl.java	Updates test mock to support new clone APIs and new base cmd type for network offering creation.
server/src/test/java/com/cloud/configuration/ConfigurationManagerImplTest.java	Adds tests around reflection helpers and some clone-related scaffolding.
server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java	Implements backup offering clone behavior and registers the command.
server/src/main/java/com/cloud/server/ManagementServerImpl.java	Registers new clone commands in management server command list.
server/src/main/java/com/cloud/network/vpc/VpcManagerImpl.java	Implements VPC offering clone logic, including service/provider/capability reconstruction.
api/src/test/java/org/apache/cloudstack/api/command/admin/vpc/CloneVpcOfferingCmdTest.java	Adds unit tests for the new clone VPC offering command.
api/src/test/java/org/apache/cloudstack/api/command/admin/offering/CloneServiceOfferingCmdTest.java	Adds unit tests for the new clone service offering command.
api/src/test/java/org/apache/cloudstack/api/command/admin/network/CloneNetworkOfferingCmdTest.java	Adds unit tests for the new clone network offering command.
api/src/test/java/org/apache/cloudstack/api/command/admin/backup/CloneBackupOfferingCmdTest.java	Adds unit tests for the new clone backup offering command.
api/src/main/java/org/apache/cloudstack/backup/BackupManager.java	Adds `cloneBackupOffering` to the backup manager interface.
api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/CreateVPCOfferingCmd.java	Adjusts supported-services behavior for external providers (validation moved server-side).
api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/CloneVPCOfferingCmd.java	New API command for cloning VPC offerings.
api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CloneServiceOfferingCmd.java	New API command for cloning service offerings.
api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CloneDiskOfferingCmd.java	New API command for cloning disk offerings.
api/src/main/java/org/apache/cloudstack/api/command/admin/network/NetworkOfferingBaseCmd.java	New base command consolidating shared network-offering params/logic.
api/src/main/java/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java	Refactors create network offering cmd to extend `NetworkOfferingBaseCmd`.
api/src/main/java/org/apache/cloudstack/api/command/admin/network/CloneNetworkOfferingCmd.java	New API command for cloning network offerings.
api/src/main/java/org/apache/cloudstack/api/command/admin/backup/ImportBackupOfferingCmd.java	Makes `backupManager` protected and annotates domainIds param with `since`.
api/src/main/java/org/apache/cloudstack/api/command/admin/backup/CloneBackupOfferingCmd.java	New API command for cloning backup offerings (domainIds resolver support).
api/src/main/java/org/apache/cloudstack/api/ApiConstants.java	Adds `SOURCE_OFFERING_ID` constant.
api/src/main/java/com/cloud/network/vpc/VpcProvisioningService.java	Adds `cloneVPCOffering` to VPC provisioning service interface.
api/src/main/java/com/cloud/event/EventTypes.java	Adds new event types for offering/backup offering clone.
api/src/main/java/com/cloud/configuration/ConfigurationService.java	Adds clone methods and generalizes `createNetworkOffering` to accept the new base cmd.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

api/src/main/java/org/apache/cloudstack/api/command/admin/backup/CloneBackupOfferingCmd.java

Copilot · 2026-02-08T15:02:03Z

ui/src/views/offering/CloneComputeOffering.vue

+export default {
+  name: 'CreateComputeOffering',
+  mixins: [mixinForm],
+  components: {


The component is registered with name 'CreateComputeOffering', but this view is for cloning. This breaks devtools/component identification and may affect caching/keep-alive behavior if other components rely on the name. Rename it to 'CloneComputeOffering' (or another clone-specific name).

Copilot · 2026-02-08T15:02:03Z

ui/src/views/offering/CloneComputeOffering.vue

+        }
+
+        params.sourceofferingid = this.resource.id
+
+        postAPI('cloneServiceOffering', params).then(json => {
+          const message = this.isSystem


this.loading is never set to true before calling postAPI('cloneServiceOffering', ...), so the submit-guard (if (this.loading) return) does not prevent double submits and the UI spinner never activates. Set this.loading = true immediately before the API call (and keep the existing finally that resets it).

api/src/main/java/org/apache/cloudstack/api/command/admin/backup/CloneBackupOfferingCmd.java

server/src/main/java/com/cloud/network/vpc/VpcManagerImpl.java

Copilot · 2026-02-08T15:02:04Z

ui/src/views/offering/CloneComputeOffering.vue

+      }).then(json => {
+        this.diskOfferings = json.listdiskofferingsresponse.diskoffering || []
+        if (this.selectedDiskOfferingId === '') {
+          this.selectedDiskOfferingId = this.diskOfferings[0].id || ''
+        }


this.diskOfferings[0].id will throw if listDiskOfferings returns an empty list. Guard with a length check (or use optional chaining) before reading the first element.

Copilot · 2026-02-08T15:02:04Z

ui/src/components/offering/DiskOfferingForm.vue

+      <a-switch v-model:checked="form.encryptdisk" :checked="encryptdisk" @change="val => { encryptdisk = val }" />
+    </a-form-item>
+    <a-form-item name="disksizestrictness" ref="disksizestrictness">
+      <template #label>
+        <tooltip-label :title="$t('label.disksizestrictness')" :tooltip="apiParams.disksizestrictness.description" />
+      </template>
+      <a-switch v-model:checked="form.disksizestrictness" :checked="disksizestrictness" @change="val => { disksizestrictness = val }" />


The switch uses both v-model:checked and an explicit :checked bound to a different data property (encryptdisk). This can desynchronize the UI from form.encryptdisk (especially when initialValues sets a non-default). Prefer binding only via v-model:checked and remove the separate :checked/@change state mirror.

Suggested change

<a-switch v-model:checked="form.encryptdisk" :checked="encryptdisk" @change="val => { encryptdisk = val }" />

</a-form-item>

<a-form-item name="disksizestrictness" ref="disksizestrictness">

<template #label>

<tooltip-label :title="$t('label.disksizestrictness')" :tooltip="apiParams.disksizestrictness.description" />

</template>

<a-switch v-model:checked="form.disksizestrictness" :checked="disksizestrictness" @change="val => { disksizestrictness = val }" />

<a-switch v-model:checked="form.encryptdisk" />

</a-form-item>

<a-form-item name="disksizestrictness" ref="disksizestrictness">

<template #label>

<tooltip-label :title="$t('label.disksizestrictness')" :tooltip="apiParams.disksizestrictness.description" />

</template>

<a-switch v-model:checked="form.disksizestrictness" />

Copilot · 2026-02-08T15:02:04Z

ui/src/components/offering/DiskOfferingForm.vue

+      <a-switch v-model:checked="form.encryptdisk" :checked="encryptdisk" @change="val => { encryptdisk = val }" />
+    </a-form-item>
+    <a-form-item name="disksizestrictness" ref="disksizestrictness">
+      <template #label>
+        <tooltip-label :title="$t('label.disksizestrictness')" :tooltip="apiParams.disksizestrictness.description" />
+      </template>
+      <a-switch v-model:checked="form.disksizestrictness" :checked="disksizestrictness" @change="val => { disksizestrictness = val }" />


Same issue as encrypt switch: v-model:checked plus explicit :checked backed by disksizestrictness can cause the displayed value to diverge from form.disksizestrictness / initialValues. Bind the switch to a single source of truth (the form model).

Suggested change

<a-switch v-model:checked="form.encryptdisk" :checked="encryptdisk" @change="val => { encryptdisk = val }" />

</a-form-item>

<a-form-item name="disksizestrictness" ref="disksizestrictness">

<template #label>

<tooltip-label :title="$t('label.disksizestrictness')" :tooltip="apiParams.disksizestrictness.description" />

</template>

<a-switch v-model:checked="form.disksizestrictness" :checked="disksizestrictness" @change="val => { disksizestrictness = val }" />

<a-switch v-model:checked="form.encryptdisk" />

</a-form-item>

<a-form-item name="disksizestrictness" ref="disksizestrictness">

<template #label>

<tooltip-label :title="$t('label.disksizestrictness')" :tooltip="apiParams.disksizestrictness.description" />

</template>

<a-switch v-model:checked="form.disksizestrictness" />

ui/src/components/offering/DiskOfferingForm.vue

api/src/main/java/com/cloud/event/EventTypes.java

api/src/main/java/org/apache/cloudstack/api/command/admin/backup/CloneBackupOfferingCmd.java

api/src/main/java/org/apache/cloudstack/api/command/admin/backup/ImportBackupOfferingCmd.java

api/src/main/java/org/apache/cloudstack/api/command/admin/network/CloneNetworkOfferingCmd.java

api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/CreateVPCOfferingCmd.java

server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java

weizhouapache

code lgtm

@Pearl1594
there are import issues

server/src/test/java/org/apache/cloudstack/backup/BackupManagerTest.java

sonarqubecloud · 2026-02-13T12:37:19Z

Quality Gate failed

Failed conditions
36.9% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

DaanHoogland · 2026-02-13T14:18:02Z

@blueorangutan package

blueorangutan · 2026-02-13T14:20:05Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-02-13T15:13:24Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16829

Add support to clone existing offerings and update them

2afc1b7

boring-cyborg bot added component:api component:management-server component:vpc labels Dec 31, 2025

Pearl1594 added 2 commits January 6, 2026 11:14

add support for vpc & backup offerings to be cloned

1ad120f

fix capability list and mapping of params

24ddfd2

boring-cyborg bot added component:backup component:networking labels Jan 6, 2026

Add support to clone network and vpc offering with the right parameters

3787aaa

Pearl1594 force-pushed the clone-edit-existing-offerings branch from 62368f3 to 3787aaa Compare January 6, 2026 22:39

DaanHoogland added this to the 4.23.0 milestone Jan 7, 2026

Pearl1594 added 2 commits January 7, 2026 11:24

make fields non mandatory for clone offerings APIs

db8fb3b

Add UI support for cloning Compute and System Service offerings

d58fea2

boring-cyborg bot added the component:UI label Jan 7, 2026

Pearl1594 added 2 commits January 8, 2026 06:58

remove unnecessary changes

b9a1c02

fix license and pre-ccommit issues

44d47ac

Pearl1594 force-pushed the clone-edit-existing-offerings branch from a5a9eb4 to bb2e90d Compare January 8, 2026 21:49

Add UI support to clone disk and network offering

7fd4567

Pearl1594 force-pushed the clone-edit-existing-offerings branch from bb2e90d to 7fd4567 Compare January 8, 2026 21:52

Pearl1594 added 3 commits January 8, 2026 22:29

vpc & backup offering clone api

cdd1250

add unit tests

786372f

fix pre-commit checks

210cb4c

boring-cyborg bot added component:marvin Python Warning... Python code Ahead! labels Jan 9, 2026

increase test coverage

3aa1040

github-actions bot added the status:has-conflicts label Jan 19, 2026

Pearl1594 added 2 commits January 20, 2026 16:33

combine add/clone disk/compute offering forms

3981d42

update license

4e97874

Pearl1594 requested a review from ustcweizhou February 2, 2026 13:26

Pearl1594 added 2 commits February 2, 2026 08:27

Merge branch 'main' of https://github.com/apache/cloudstack into clon…

09cdd31

…e-edit-existing-offerings

add some checks to prevent networkmode change when provider is nsx/ne…

6ea054c

…tris from the source networkmode

Pearl1594 closed this Feb 2, 2026

Pearl1594 reopened this Feb 2, 2026

Pearl1594 closed this Feb 2, 2026

Pearl1594 reopened this Feb 2, 2026

weizhouapache requested review from Copilot and weizhouapache and removed request for ustcweizhou February 3, 2026 15:45

Copilot started reviewing on behalf of weizhouapache February 8, 2026 14:51 View session

Copilot AI reviewed Feb 8, 2026

View reviewed changes

address copilot comments

425d8c7

weizhouapache reviewed Feb 11, 2026

View reviewed changes

Pearl1594 added 3 commits February 11, 2026 09:45

address comments

ec53d6f

combine check

255144f

fix build failure

1c18d31

weizhouapache reviewed Feb 11, 2026

View reviewed changes

server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java Outdated Show resolved Hide resolved

weizhouapache reviewed Feb 11, 2026

View reviewed changes

server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java Outdated Show resolved Hide resolved

use appropriate zoneId during clone bkp offering

00850ea

weizhouapache reviewed Feb 11, 2026

View reviewed changes

server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java Outdated Show resolved Hide resolved

Pearl1594 added 2 commits February 12, 2026 11:26

add check

021fb88

fix issue with test

57eb794

weizhouapache approved these changes Feb 12, 2026

View reviewed changes

remove unused imports

9907d5a

weizhouapache reviewed Feb 13, 2026

View reviewed changes

server/src/test/java/org/apache/cloudstack/backup/BackupManagerTest.java Outdated Show resolved Hide resolved

Conversation

Pearl1594 commented Dec 31, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Jan 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Feb 13, 2026

Quality Gate failed

Uh oh!

DaanHoogland commented Feb 13, 2026

Uh oh!

blueorangutan commented Feb 13, 2026

Uh oh!

blueorangutan commented Feb 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Dec 31, 2025 •

edited

Loading